nice
theoretically i am in charge here. message me on discord or xmpp if something serious happens
— ubq323
- joined
- a very long time ago
recent posts
arcade: this looks good. things:
- the visited link colour doesn't seem to be quite right (ie, it's not the same as the browser's default). but i think the browser default colour differs across browsers so it's probably not possible to fix this (unless you avoid overriding it entirely on light mode, but i'm not sure if that's a reasonable thing to do?)
- everything else looks good though, on dark and light themes
- i notice that you have introduced a
!important. if possible it would be good to avoid this but it might not be, i know the css needs some refactoring anyway (and it already has an!importantelsewhere anyway).
could you git rebase this into a single commit before i merge it?
(also, in the future, it might be easier to send me patches via git send-email, since it's slightly more convenient to do code review in general if i can point directly to parts of the diff. also, pulling in the commit is then a lot easier, i can just pipe the email to git am. (setting up a proper mailing list for apioforum development is on my to do list as well))
i don't plan on adding hooks to my server to interface with external services (especially proprietary services) unless there is a particularly compelling reason to
what's your reason for wanting your github mirror to always be up to date? can't you just do git pull and then git push on your local machine when you need the github mirror to be updated? (or indeed set up something to do that periodically)
i am not sure if it's possible to get github to automatically pull changes in from an external repo; i would imagine it isn't
because that is the simplest voting system and i had enough "trauma" from writing a voting website app years ago that i somehow didn't consider supporting multiple voting systems. in retrospect this was not a very good idea and it probably needs a bit of work.
honestly the apioforum voting system has always been slightly half baked. there's still no way to close polls, or any way to see who is voting for which options in one place.
contributions are always welcome of course. if you want to learn git i would recommend the official git book, which you can read for free on their website.
